Bluetooth: CCP: Introduce new CCP API #77120
Conversation
Thalley
force-pushed
the
ccp_register
branch
3 times, most recently
from
6aa67a6 to
63398a4
Compare
Thalley
force-pushed
the
ccp_register
branch
6 times, most recently
from
4599b32 to
fc5da98
Compare
include/zephyr/bluetooth/audio/ccp.h
Outdated
There was a problem hiding this comment.
For reviewers: I consider the following naming options:
- bt_ccp_ccs (Bluetooth Call Control Profile Call Control Server, where Call Control Server is the actual name of the role in CCP)
- bt_ccp_call_control_server (more verbose version of the above; naming similar to e.g. bt_bap_unicast_server)
- bt_ccp_call_ctrl_srv (shorter version of 3, more similar to the VCP and MICP APIs (e.g. bt_vcp_vol_rend)
- bt_ccp_server (and in upcoming PRs, bt_ccp_client).
If you have any preferences or other suggestions, please let me know and we can just do a rename
There was a problem hiding this comment.
I prefer 3. bt_ccp_call_control_server. It is easier to spelling and understand.
There was a problem hiding this comment.
Thanks for your input - Other reviews please also comment here about what you prefer
There was a problem hiding this comment.
No strong preferences, but I do in general prefer longer, more readable names.
There was a problem hiding this comment.
@koffes is that a vote for 3) then?
Thalley
force-pushed
the
ccp_register
branch
4 times, most recently
from
87437d8 to
1e8dcd7
Compare
Thalley
force-pushed
the
ccp_register
branch
6 times, most recently
from
87a92cf to
3c73258
Compare
Thalley
force-pushed
the
ccp_register
branch
9 times, most recently
from
0ede37d to
c3c5f3f
Compare
Thalley
force-pushed
the
ccp_register
branch
from
90f3646 to
c53b52c
Compare
Thalley
force-pushed
the
ccp_register
branch
from
c53b52c to
62367c9
Compare
There was a problem hiding this comment.
| In the following examples, notifications from GTBS is ignored, unless otherwise | |
| In the following examples, notifications from GTBS are ignored, unless otherwise |
This was also wrong in the original document, but suggest to fix it here
Thalley
force-pushed
the
ccp_register
branch
from
62367c9 to
844a3e1
Compare
Thalley
force-pushed
the
ccp_register
branch
from
844a3e1 to
4c8106b
Compare
There was a problem hiding this comment.
| Starts by advertising for a CCP Clients to connect and set up calls. | |
| Starts by advertising for CCP Clients to connect and set up calls. |
There was a problem hiding this comment.
5.3 is not required :)
There was a problem hiding this comment.
maybe make sure adv is 0 on init
Thalley
force-pushed
the
ccp_register
branch
2 times, most recently
from
067ce29 to
2563cf7
Compare
|
Renamed to Call Control Profile Call Control Server as per #77120 (comment) and short discussion in the weekly LE Audio meeting |
Thalley
force-pushed
the
ccp_register
branch
4 times, most recently
from
6bc5e73 to
ad74b1d
Compare
The CCP API for the Call Control Profile works on top of the TBS API, and will eventually replace parts of the TBS API. Signed-off-by: Emil Gydesen <[email protected]>
12 participants
The CCP API for the Call Control Profile works on top of the
TBS API, and will eventually replace parts of the TBS API.
Signed-off-by: Emil Gydesen [email protected]